Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a workaround patch for #1652 #1807

Merged
merged 1 commit into from
Jun 18, 2020

Conversation

daisukes
Copy link
Contributor

Signed-off-by: Daisuke Sato [email protected]

Basic Info

Info Please fill out this column
Ticket(s) this addresses #1652
Primary OS tested on Ubuntu
Robotic platform tested on turtlebot

Description of contribution in a few bullet points

Description of documentation updates required from your changes

N/A


Future work that may be required in bullet points

@codecov
Copy link

codecov bot commented Jun 18, 2020

Codecov Report

Merging #1807 into master will increase coverage by 1.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1807      +/-   ##
==========================================
+ Coverage   65.94%   67.07%   +1.12%     
==========================================
  Files         200      200              
  Lines       10532    10532              
==========================================
+ Hits         6945     7064     +119     
+ Misses       3587     3468     -119     
Flag Coverage Δ
#project 67.07% <100.00%> (+1.12%) ⬆️
Impacted Files Coverage Δ
...tree/include/nav2_behavior_tree/bt_action_node.hpp 79.26% <100.00%> (+3.65%) ⬆️
...v2_util/include/nav2_util/simple_action_server.hpp 88.27% <0.00%> (ø)
nav2_amcl/src/amcl_node.cpp 83.84% <0.00%> (+0.60%) ⬆️
nav2_costmap_2d/plugins/voxel_layer.cpp 45.66% <0.00%> (+1.36%) ⬆️
nav2_costmap_2d/plugins/obstacle_layer.cpp 82.75% <0.00%> (+1.37%) ⬆️
nav2_controller/src/nav2_controller.cpp 81.21% <0.00%> (+2.03%) ⬆️
nav2_costmap_2d/src/costmap_2d_ros.cpp 85.27% <0.00%> (+2.71%) ⬆️
..._dwb_controller/dwb_core/src/dwb_local_planner.cpp 82.29% <0.00%> (+4.96%) ⬆️
nav2_recoveries/plugins/spin.cpp 94.73% <0.00%> (+5.26%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd2955a...23839e9. Read the comment docs.

Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super clean and concise, I really appreciate that. Great workaround.

@SteveMacenski SteveMacenski merged commit dc59715 into ros-navigation:master Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants